Andrew, Add checking of the flag online still does not answer the race that Vlad stated before, unless you thought about another way without lock to protect this thread. > Nope, taking only one that hunk from this patch isn't sufficient. > Around > dpc_thread there is pretty simple and classical race. You can't do > > if (x != NULL) > y = *x; > > without any protection, if x can be set to NULL by another thread. It > can happen exactly between "if" and "*x" and hence lead to a crash, > correct? Gal. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html