On Fri, 2008-07-04 at 15:45 +0200, Hannes Reinecke wrote: > Hi James, > > these patches just fix the suggestions made by you and Mike C. > - Check the return code from try_module_get() > - Use GFP_ATOMIC in the IO path I thought the final agreement was that these should be GFP_NOIO? > Patches apply on top of my previous patchset for the scsi_dh fixes. Could you not do this? The GFP_KERNEL will spit might sleep warnings on certain configs and the try_module_get could cause an oops on removal. Either of these might confuse a bisection search if it accidentally landed in them. In general, for unapplied patches with identified bugs, the patches should be fixed before applying. Thanks, James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
