On Thu, 2008-07-03 at 23:47 -0700, akpm@xxxxxxxxxxxxxxxxxxxx wrote: > From: Akinobu Mita <akinobu.mita@xxxxxxxxx> > > Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx> > Cc: Andrew Vasquez <linux-driver@xxxxxxxxxx> > Cc: James E.J. Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> > Tested-by: Andrew Vasquez <andrew.vasquez@xxxxxxxxxx> > Cc: Seokmann Ju <seokmann.ju@xxxxxxxxxx> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > --- > > drivers/scsi/qla2xxx/qla_attr.c | 45 ++++++------------------------ > 1 file changed, 10 insertions(+), 35 deletions(-) > > diff -puN drivers/scsi/qla2xxx/qla_attr.c~qla2xxx-use-memory_read_from_buffer drivers/scsi/qla2xxx/qla_attr.c > --- a/drivers/scsi/qla2xxx/qla_attr.c~qla2xxx-use-memory_read_from_buffer > +++ a/drivers/scsi/qla2xxx/qla_attr.c > @@ -8,6 +8,7 @@ > > #include <linux/kthread.h> > #include <linux/vmalloc.h> > +#include <linux/fs.h> For such a micro optimisation, this is a pretty big price to pay. Inclusion of linux/fs.h in a low level driver was always a danger signal usually it meant the driver was trying to access files or something at the very least it was a warning of a potential layering violation. Now you're trying to make it standard practice ... I really don't like that. Surely a function that does memory to memory copies belongs either in string.h with the rest of our memory copies ... or in another header that would be a usual include for the potential users. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
