On Wed, 2008-05-14 at 16:43 +0200, Hannes Reinecke wrote: <snip> > > @@ -438,10 +604,32 @@ static int clariion_bus_attach(struct scsi_device *sdev) > sdev->scsi_dh_data = scsi_dh_data; > spin_unlock_irqrestore(sdev->request_queue->queue_lock, flags); > Can move the block above to be just before try_module_get() and avoid undoing it in the failed path. > - sdev_printk(KERN_NOTICE, sdev, "Attached %s.\n", CLARIION_NAME); > + err = clariion_std_inquiry(sdev); > + if (err != SCSI_DH_OK) > + goto failed; > + > + err = clariion_send_inquiry(sdev); > + if (err != SCSI_DH_OK) > + goto failed; > + -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
