On Mon, 2008-04-28 at 13:04 -0600, Matthew Wilcox wrote: > it returns -EINTR and it's > up to the caller to handle it and unwind back to userspace. ie it's > halfway between mutex_lock_interruptible() (any signal) and > mutex_lock() > (no signal). In the hunk you quoted (below), > > - down(&qla_fw_lock); > > + if (mutex_lock_killable(&qla_fw_lock)) > > + return NULL; Don't you need to return the -EINTR so the caller knows the nature of the failure? You might also need to re-factor the caller of this function so it properly reports the failure to userspace .. In this case your just returning NULL .. (CC'd Andrew since I think this was something he was concerned about, with mutex_lock_interruptible().) Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
