Re: [PATCH 1/2] dpt_i2o: 64 bit support (take 3)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2008-04-24 at 10:39 -0500, James Bottomley wrote:
> Just gave it a cursory glance, and it looks OK, except for things like
> this:
> 
> On Thu, 2008-04-24 at 17:07 +0200, Miquel van Smoorenburg wrote:
> > +#elif defined(__linux__)
> 
> Could you get rid it, please?  For inclusion in the kernel, you can take
> it as read that we're operating in a Linux environment, so the symbol
> will always be defined (so you can just strip out the code that depends
> on this symbol not being defined).

Ofcourse. I did it this way because I wanted to follow the style of the
existing code as much as possible, and I did not want to change the
existing code too much. There's more stuff in there that needs a
cleanup, but that needs to be done seperately.

I'll fix the defined(__linux__) stuff, and I'll rip out the unused
reboot_notifier stuff as well.

Mike.

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux