In article <xs4all.200804232329.22140.eike-kernel@xxxxxxxxx> you write: >Miquel van Smoorenburg wrote: >> * 64 bit code based on unofficial Adaptec 64 bit driver >> * removes scsi_module.c dependency, adds module_init / module_exit >> this is needed because we need to pass the proper device to >> scsi_add_host(), and the scsi_module.c passes NULL. With NULL, >> code like arch/x64/kernel/pci-gart_64.c::need_iommu() crashes >> because the dev pointer it is passed is NULL. >> * adds sysfs entry for /sys/class/dpt_i2o/dptiX so that udev >> can create /dev/dptiX dynamically > >Is there any chance that you could split this into (at least) 2 patches, one >for the 64 bit stuff and one for the driver model stuff? This patch is huge, >the review (and the chances for this getting merged) will be higher if it is >in small pieces. The sysfs is stuff is just a few lines, but sure .. The dpt_i2o driver works fine, but code-wise it isn't in terrific shape. This patch does make some things cleaner, but it's not a complete rewrite - on purpose. So when revieuwing the patch, keep the context in mind. General cleanups, not related to the 64-bit code, can be done later. Mike. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
