On Thu, 2008-03-27 at 14:54 +0800, Ke Wei wrote: > When a slot is busy, we will not free this slot until slot reset is completed. > When unplugged the disk, we should release all command tasks with unplugged port that have been sent. > If MVS_USE_TASKLET is defined, we can enable tasklet. Default is off. This tasklet usage doesn't quite look right. What a tasklet does is defer processing until after all interrupts have completed. It's commonly used for aggregation, which is why scsi_done simply queues for the block softirq (tasklet). However, for mvsas, I don't see any benefit to defering the work to a tasklet. Additionally, for the non MSI case, doesn't the interrupt, which is level triggered, fail to deassert because we haven't cleared any registers? James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html