On Fri, Mar 28, 2008 at 4:51 PM, James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote: ... > So basically, most of the cpu_to_le32 in this driver look wrong. If I > can fix it (or persuade someone else to fix it) can anyone test it on a > BE platform? But the code I submitted the patch is also broken for LE platforms. (As you pointed out earlier and was my original incentive for submitting the patch). If most of the usage is wrong anyway, perhaps it's better to not pretend the driver can work on a BE platform and just rip all the cpu_to_le32() usage out...including the one I submitted the patch for. Either way, that change should go in. Right? hth, grant -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
