Re: [patch 08/17] scsi: replace remaining __FUNCTION__ occurrences

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 28 Mar 2008 17:35:04 -0500
James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote:

> On Fri, 2008-03-28 at 14:48 -0700, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> > From: Harvey Harrison <harvey.harrison@xxxxxxxxx>
> > 
> > __FUNCTION__ is gcc-specific, use __func__
> 
> I thought we basically agreed

No.

> there was no point to this since if it
> ever became an issue you can do 
> 
> #define __FUNCTION__ __func__
> 
> inside the include/compiler-xxx.h file
> 

It's better to get things right at the original code site, rather than
adding crufty back-compatibility macros.

The patches are easy to prepare, easy to review and easy to merge.  There's
no reason to not do so.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux