Re: [patch 08/11] zfcp: Add traces for state changes.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -	zfcp_erp_modify_adapter_status(adapter,
> +	zfcp_erp_modify_adapter_status(adapter, 24, 0,
>  				       ZFCP_STATUS_COMMON_OPEN, ZFCP_CLEAR);
>  }
> 
> @@ -216,7 +216,7 @@ zfcp_erp_adapter_reopen_internal(struct 
>  			       zfcp_get_busid_by_adapter(adapter));
>  		debug_text_event(adapter->erp_dbf, 5, "a_ro_f");
>  		/* ensure propagation of failed status to new devices */
> -		zfcp_erp_adapter_failed(adapter);
> +		zfcp_erp_adapter_failed(adapter, 13, 0);

24, 13? I bet you made sure that these numbers fit the huge list.. and
hopefully nobody will ever add anything in between.
Why not just pass a string? This looks way too complicated and error-prone.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux