On Mon, Mar 24, 2008 at 10:24:07AM -0500, James Bottomley wrote: > > On Mon, 2008-03-24 at 15:00 +0100, Eric Piel wrote: > > Since commit 751bf4d7865e4ced406be93b04c7436d866d3684 (scsi_sysfs: > > restore prep_fn when ULD is removed), the warning "Driver '%s' needs > > updating - please use bus_type methods." is generated for several scsi > > drivers (sr, sg, st and osst). It does so because it thinks that the > > driver remove() functions will not be called (cf > > __device_release_driver()). Actually, they are called by scsi_bus_remove(). > > > > This has been noted already a couple of times [1] [2] [3], but it seems > > absolutely nothing conclusive came out of the reports. > > > > What should be done? Delete the warning? Change it so it doesn't get > > triggered if drv->bus->remove == scsi_bus_remove? Merge > > scsi_bus_remove() into the driver remove() functions? Disregard the > > monthly warming reports? > > At least for SCSI, the warning is wrong .. the drivers are properly > converted. The issue that triggers the warning is that we use the > bus_type power management methods to receive the notifies in the > mid-layer (where we do mid-layer specific stuff) then we notify the > drivers through the driver power management methods. > > A solution would be to duplicate the power management methods in the > scsi_driver structure, but this is a complete waste of space since the > generic driver ones aren't going away (at least according to Kay and > Greg). I still think the best thing to do is just to turn off this > spurious warning. Do you have a patch that can detect the usage that you currently have so that I can change the warning message to not trigger if things are set up that way instead? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
