On Fri, Mar 14 2008 at 16:24 +0200, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Fri, Mar 14, 2008 at 02:51:35PM +0100, Jens Axboe wrote: >> Are you sure? Seems to me that st builds its own list with >> get_user_pages() for direct io, where will that get bounced? The block >> layer will only bounce things that are mapped directly, so if st used >> blk_rq_map_kern() and inserted that request in the queue, we could >> proceed with killing that check in st. > > Which shouldn't be all too difficult and would be the right thing to > do. We really need someone to sit down and convert st/osst/sg to use > the proper block layer helpers. > First they do. They all call scsi_execute_async which at the end produces a BIO and then calls blk_execute_nowait(). and all is swell. Second some one did, long a go, and have submitted them rebased more then 3 times. I'd say their time is do long a go. (I mean Mike Christie) Mike, please, do you have these patches on a public git somewhere I want to help push them. Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html