On Thu, Mar 06, 2008 at 04:13:27PM -0600, James Bottomley wrote: > On Thu, 2008-03-06 at 21:51 +0100, Andi Kleen wrote: > > This is v2 of the patchkit. I believe I addressed all review feedback > > and did some more improvements. > > I believe I objected to substituting the single bit unchecked_isa_dma > flag with a u64 sense_mask. That still seems to be present: Ok. It was a micro optimization because I realized most drivers I looked at don't need sense_buffer bouncing (because they don't don't dma it). But I don't feel very strongly about optimizing these drivers. I guess I can move it over to blk_kmalloc() too. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html