On Thu, 2008-03-06 at 21:51 +0100, Andi Kleen wrote:
> This is v2 of the patchkit. I believe I addressed all review feedback
> and did some more improvements.
I believe I objected to substituting the single bit unchecked_isa_dma
flag with a u64 sense_mask. That still seems to be present:
> @@ -649,7 +657,7 @@ struct Scsi_Host {
> unsigned char n_io_port;
> unsigned char dma_channel;
> unsigned int irq;
> -
> + u64 sense_buffer_mask;
I particularly object to this, because it defeats the whole idea of
removing the special casing for ISA devices. If you look at how you use
this flag in a lot of your code, it's a straightforward substitution:
> @@ -1355,7 +1377,7 @@ static int port_detect(unsigned long por
>
> for (i = 0; i < shost->can_queue; i++) {
> size_t sz = shost->sg_tablesize *sizeof(struct sg_list);
> - gfp_t gfp_mask = (shost->unchecked_isa_dma ? GFP_DMA : 0) | GFP_ATOMIC;
> + gfp_t gfp_mask = (shost->sense_buffer_mask ? GFP_DMA : 0) | GFP_ATOMIC;
If you're using it as a bit flag, just call it unchecked_isa_dma. If
you really want it to be a mask, then I think setting up and using the
mask in sdev->sdev_gendev is the way to go.
James
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
