On Tue, Feb 26, 2008 at 07:18:18AM -0800, James Bottomley wrote: > On Tue, 2008-02-26 at 04:44 +0100, Andi Kleen wrote: > > No pci_alloc_coherent works, but pci_map_* will not. > > Yes, it does ... dma_map is a flush/virt_to_phys on x86. so of course it > works. If you mean it doesn't transform from > 24 bit phys to < 24 bit > phys, then yes; but that's not an API requirement; that's what bounce > buffering is all about, so for ISA devices we always only call dma_map > on < 24 bit phys addresses and it all works. Actually, tomo's patch violates that ... asc_dvc_varp->overrun_buf = kzalloc(ASC_OVERRUN_BSIZE, GFP_KERNEL); [...] asc_dvc->overrun_dma = dma_map_single(board->dev, asc_dvc->overrun_buf, ASC_OVERRUN_BSIZE, DMA_FROM_DEVICE); There's a missing check for ISA boards and GFP_DMA. Honestly, I'd rather over-allocate asc_dvc_varp->overrun_buf by 4 bytes and map the appropriate alignment. Patch next week, probably. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
