On Mon, Feb 25, 2008 at 02:47:46PM -0700, Matthew Wilcox wrote: > On Mon, Feb 25, 2008 at 12:35:16AM +0100, Andi Kleen wrote: > > That patch is a little more complicated than the others. advansys > > was the only ISA driver who actually passed ->cmnd to the firmware. > > So I implemented a simple own bounce buffer scheme for this case. > > Also did sense_buffer bouncing in the driver while I was at it; > > which means it doesn't require the mid layer to do this anymore. > > I have to say I really don't like this patch. I'll look up my current Why do you not like it? What would you do better? > patch queue for this driver next week -- I think I fixed this differently. > (I must have fixed it somehow because it works on parisc, which is most > unforgiving of drivers which do DMA without the DMA API). At least on x86 the DMA API cannot do ISA bouncing. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html