On Sun, Feb 24, 2008 at 12:18:23AM -0500, Jeff Garzik wrote: > hmmmmm. We'll see how it plays out... on the remove side, the above is > exact what happens in gdth_remove_one() without my patch, thus > consolidating two cases of the same code into one. There is a less-strong > argument for doing the allocation that way, but it may turn out to be > useful anyway once the ISA/EISA API conversion is complete. EISA ->remove has a different prototype from PCI ->remove from ISA ->remove, so gdth_remove_one will be split up eventually. Having the scsi_host_put duplicated in each shouldn't be too much of a problem :) - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html