On Wed, 2008-02-20 at 11:10 -0700, Matthew Wilcox wrote: > There is no need to allocate this memory atomically. There is no problem > with sleeping during a bus scan, and it's actually causing problems > for libata. This bit is fine. > Also remove the GFP_DMA flag. If it's needed, the block layer will > bounce-buffer it. Just because the block layer is capable of doing it doesn't mean we should automatically force it. Bounce buffers are scarce resources, and since we know they're required and we know that kmalloc allocates from the top of its pools, and so will *always* require bouncing, doesn't it make sense simply to save it the trouble? James - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
