> -----Original Message----- > From: Andrew Morton [mailto:akpm@xxxxxxxxxxxxxxxxxxxx] > Sent: Tuesday, February 19, 2008 6:00 AM > To: Jens Axboe > Cc: Miller, Mike (OS Dev); LKML; LKML-scsi > Subject: Re: [PATCH 1/1] cciss: procfs updates to display > info about many volumes > > On Tue, 19 Feb 2008 11:48:18 +0100 Jens Axboe > <jens.axboe@xxxxxxxxxx> wrote: > > > On Mon, Feb 11 2008, Mike Miller wrote: > > > Patch 1 of 1 > > > > > > This patch allows us to display information about all of > the logical > > > volumes configured on a particular without stepping on > memory even > > > when there are many volumes (128 or more) configured. This patch > > > replaces the one submitted on 20071214. See > > > > http://groups.google.com/group/linux.kernel/browse_thread/thread/49a > > > > 50244b19f8855/ba3dc95b23391521?hl=en&lnk=gst&q=cciss#ba3dc95b2339152 > > > 1 which has not been merged. That patch displayed > information about > > > only the first logical volume on each controller and had negative > > > side effects for some installers. > > > Please consider this for inclusion. > > > > It looks ok, but has some flaws. Try to disable cciss scsi and tape > > support: > > > > In file included from drivers/block/cciss.c:231: > > drivers/block/cciss_scsi.c:1498:38: error: macro parameters must be > > comma-separated > > drivers/block/cciss.c: In function 'cciss_seq_show_header': > > drivers/block/cciss.c:272: error: implicit declaration of function > > 'cciss_seq_tape_report' > > drivers/block/cciss.c: In function 'cciss_proc_write': > > drivers/block/cciss.c:393: error: implicit declaration of function > > 'cciss_engage_scsi' > > > > You macro definition of cciss_seq_tape_report() is totally busted. > > Either write is as a macro OR as a function. > > > > Fix these up and resubmit, then I'll take it. > > > > It also need to be updated to use the non-racy proc_create(), > please, as per Alexey's comments. Thanks all, I'll fix and resubmit. -- mikem > - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
