On Tue, 2008-02-19 at 17:02 +0900, FUJITA Tomonori wrote: > ips did scsi_add_host(sh, NULL) so scsi_dma_map uses > shost_gendev.parent that isn't initialized properly, then the kernel > crashes. 2.6.23 and 2.6.24 have this bug. > > We can fix this by calling scsi_add_host with pdev->dev, in the > standard way (like the following way) but this bug was fixed in the > current Linus tree by: > > commit 2551a13e61d3c3df6c2da6de5a3ece78e6d67111 > Author: Jeff Garzik <jeff@xxxxxxxxxx> > Date: Thu Dec 13 16:14:10 2007 -0800 > > [SCSI] ips: handle scsi_add_host() failure, and other err cleanups > > > James, the legitimate way to fix stable trees is sending this commit > (not sending a patch that was not committed upstream)? Well, the upstream patch doesn't look so bad as a stable candidate to my eye. Just because it's an unintended bugfix doesn't automatically invalidate it. The reason stable likes backports of existing upstream patches is because they've supposedly been well tested in upstream. Although that doesn't apply in this case because the other bug rather prevented testing, the principle is still sound. So, would there be any problems simply backporting this? James - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
