ACK Wonderful work Tom and Fujita-san! Sincerely -- Mark Salyzyn > -----Original Message----- > From: FUJITA Tomonori [mailto:tomof@xxxxxxx] > Sent: Tuesday, February 19, 2008 3:02 AM > To: linux-scsi@xxxxxxxxxxxxxxx > Cc: James.Bottomley@xxxxxxxxxxxxxxxxxxxxx; Salyzyn, Mark; > lnxninja@xxxxxxxxxxxxxxxxxx; fujita.tomonori@xxxxxxxxxxxxx > Subject: [PATCH] ips: fix data buffer accessors conversion bug > > There is one more bug in ips. I think that this needs to go to > scsi-rc-fixes, 2.6.24-stable, and 2.6.23-stable though we might rarely > hit this bug. > > = > From: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> > Date: Tue, 19 Feb 2008 16:03:47 +0900 > Subject: [PATCH] ips: fix data buffer accessors conversion bug > > This fixes a bug that can't handle a passthru command with more than > two sg entries. > > Big thanks to Tim Pepper for debugging the problem. > > Signed-off-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> > Cc: Tim Pepper <lnxninja@xxxxxxxxxxxxxxxxxx> > Cc: Salyzyn, Mark <Mark_Salyzyn@xxxxxxxxxxx> > Cc: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> > --- > drivers/scsi/ips.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/scsi/ips.c b/drivers/scsi/ips.c > index bb152fb..7ed568f 100644 > --- a/drivers/scsi/ips.c > +++ b/drivers/scsi/ips.c > @@ -1576,7 +1576,7 @@ ips_make_passthru(ips_ha_t *ha, struct > scsi_cmnd *SC, ips_scb_t *scb, int intr) > METHOD_TRACE("ips_make_passthru", 1); > > scsi_for_each_sg(SC, sg, scsi_sg_count(SC), i) > - length += sg[i].length; > + length += sg->length; > > if (length < sizeof (ips_passthru_t)) { > /* wrong size */ > -- > 1.5.3.7 > > - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
