On Sun, 17 Feb 2008, FUJITA Tomonori wrote:
> ps3rom does:
>
> scsi_for_each_sg(cmd, sgpnt, scsi_sg_count(cmd), k) {
> kaddr = kmap_atomic(sg_page(sgpnt), KM_IRQ0);
>
> We cannot do something like that with the clustering enabled (or we
> can use scsi_kmap_atomic_sg).
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>
> Cc: Geert Uytterhoeven <Geert.Uytterhoeven@xxxxxxxxxxx>
> Cc: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
Seems to (still) work fine..
James: as you're scripts seem to be waiting for an ack from me, and it's not
really obvious to me whether this patch is needed or not, I'll leave it up to
you.
> ---
> drivers/scsi/ps3rom.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/ps3rom.c b/drivers/scsi/ps3rom.c
> index 0cd614a..90985cd 100644
> --- a/drivers/scsi/ps3rom.c
> +++ b/drivers/scsi/ps3rom.c
> @@ -427,7 +427,7 @@ static struct scsi_host_template ps3rom_host_template = {
> .cmd_per_lun = 1,
> .emulated = 1, /* only sg driver uses this */
> .max_sectors = PS3ROM_MAX_SECTORS,
> - .use_clustering = ENABLE_CLUSTERING,
> + .use_clustering = DISABLE_CLUSTERING,
> .module = THIS_MODULE,
> };
With kind regards,
Geert Uytterhoeven
Software Architect
Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
Phone: +32 (0)2 700 8453
Fax: +32 (0)2 700 8622
E-mail: Geert.Uytterhoeven@xxxxxxxxxxx
Internet: http://www.sony-europe.com/
Sony Network and Software Technology Center Europe
A division of Sony Service Centre (Europe) N.V.
Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium
VAT BE 0413.825.160 · RPR Brussels
Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619
