On Sat, 2008-02-16 at 11:49 +0000, Daniel Drake wrote: > I assume you're aware that this patch is just a subset of commit > 76d78300a6eb8 which you've already pushed up to Linus. Adding Nick Cheng > (commit author) to CC so that he can go over the feedback. Well, in case it's not obvious by now: The way to get bad code upstream is to send a patch that combines many changes (the more the better) so that any potential reviewer has no idea which change is meant by which hunk and then to make sure Andrew picks it up so he'll hound the subsystem Maintainer until it's applied. Best of all, mention that it fixes a bug and you're made. In this case, the problems with the changes weren't obvious to me until I saw the broken out diff for the backport. (And incidentally, never send URLs to code; 95% of people don't click on them. If you inline the code, most people at least glance over it). The odd thing is, it should have triggered a might_sleep() warning under testing ... do you know why it didn't? James - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
