On Wed, 2008-02-13 at 18:33 +0200, Boaz Harrosh wrote: > On Wed, Feb 13 2008 at 17:54 +0200, Boaz Harrosh <bharrosh@xxxxxxxxxxx> wrote: > > On Wed, Feb 13 2008 at 17:44 +0200, James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote: > >> On Tue, 2008-02-12 at 19:40 +0200, Boaz Harrosh wrote: > >>> - gdth_flush(ha); > >>> - > >> This piece doesn't look right. gdth_flush() forces the internal cache > >> to disk backing. If you remove it, you're taking the chance that the > >> machine will be powered off without a writeback which can cause data > >> corruption. > >> > >> James > >> > > Yes. > > I have more problems reported, with exit, and am just sending one more patch that puts > > this back in. Which was tested. > > > > So I will resend this one plus one new one. > > > > Boaz > > > > The gdth driver would do a register_reboot_notifier(&gdth_notifier); > to a gdth_halt() function, which would then redo half of what gdth_exit > does, and wrongly so, and crash. > > Are we guaranteed in todays kernel that modules .exit function be called > on an halt or reboot? If so then there is no need for duplications and > the gdth_halt() should go. No. The __exit section is actually discardable if you promise never to remove the module. James - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
