On Sun, Feb 10, 2008 at 03:07:09PM +0200, Boaz Harrosh wrote: > On Sat, Feb 09 2008 at 2:04 +0200, Adrian Bunk <adrian.bunk@xxxxxxxxx> wrote: > > Commit 30b0c37b27485a9cb897bfe3824f6f517b8c80d6 causes the following > > compile error: > > > > <-- snip --> > > > > ... > > CC drivers/scsi/arm/fas216.o > > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/scsi/arm/fas216.c: In function 'fas216_std_done': > > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/scsi/arm/fas216.c:2120: error: 'struct scsi_cmnd' has no member named 'request_bufflen' > > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/scsi/arm/fas216.c:2122: error: 'struct scsi_cmnd' has no member named 'use_sg' > > make[4]: *** [drivers/scsi/arm/fas216.o] Error 1 > > > > <-- snip --> > > > > cu > > Adrian > > > It's in mainline 84ac86ca8c6787f9efff28bc04b1b65fe0a5c310 > [SCSI] arm: convert to accessors and !use_sg cleanup > > Thanks for checking. This patch was in scsi-pending tree since forever, And we were unable > to get a responsive maintainer to ACK on them. until the breakage cause went into mainline > we finally managed a Tested-by:. > > I guess sometimes people are so busy, you need a bulldozer to shove 20 minutes into they're > schedule. Oh, just 20 minutes in your opinion? Reality works at a different tick rate to your timing then. However, if you're seeing a bulid error, it means that the *WRONG* patch went in. No idea why I even bothered to test it if that's what happens. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html