Thanks for performing my compile check for me ;-}. You nailed the problem on the head. <excuse>In my efforts to trim down the patch from my internal version of the driver, I neglected to pass the '#include <linux/pci.h>' chunk. Sadly, my only compile check was done against an older FC release, related to the customer request, and one should note that we removed the include <linux/pci.h> line in sa.c in May last year (join_rx_rkt.patch) post that FC release only to need to reinstate it a year later with this patch. Sigh.</excuse> This patch is against current scsi-misc-2.6. It has been checkpatch.pl and compile tested against today's scsi-misc-2.6! ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patch attachments. Signed-off-by: Mark Salyzyn <aacraid@xxxxxxxxxxx> drivers/scsi/aacraid/aachba.c | 56 ++++++++++++++++++++++++++++++----------- drivers/scsi/aacraid/aacraid.h | 2 + drivers/scsi/aacraid/linit.c | 32 ++++++++++++----------- drivers/scsi/aacraid/rx.c | 5 ++- drivers/scsi/aacraid/sa.c | 5 ++- 5 files changed, 67 insertions(+), 33 deletions(-) Sincerely -- Mark Salyzyn > -----Original Message----- > From: James Bottomley [mailto:James.Bottomley@xxxxxxxxxxxxxxxxxxxxx] > Sent: Thursday, February 07, 2008 7:31 PM > To: Salyzyn, Mark > Cc: 'linux-scsi@xxxxxxxxxxxxxxx' > Subject: Re: [PATCH 1/1] aacraid: add optional MSI support. > > > On Wed, 2008-02-06 at 13:20 -0800, Salyzyn, Mark wrote: > > Added support for MSI utilizing the aacraid.msi=1 > parameter. This patch adds some localized or like-minded > janitor fixes. Since the default is disabled, there is no > impact on the code paths unless the customer wishes to > experiment with the MSI performance. > > > > This patch is against current scsi-misc-2.6 > > It doesn't seem to compile: > > drivers/scsi/aacraid/sa.c: In function 'aac_sa_init': > drivers/scsi/aacraid/sa.c:388: error: dereferencing pointer > to incomplete type > drivers/scsi/aacraid/sa.c:406: error: dereferencing pointer > to incomplete type > > It looks like this can be corrected by #include <linux/pci.h> > since it's > struct pci_dev that's the incomplete type. > > James > > >
Attachment:
aacraid_msi2.patch
Description: aacraid_msi2.patch
