James, I acked this patch on 11/28. We are fine with the change proposed. Regards, Sumant -----Original Message----- From: James Bottomley [mailto:James.Bottomley@xxxxxxxxxxxxxxxxxxxxx] Sent: Thursday, February 07, 2008 4:41 PM To: akpm@xxxxxxxxxxxxxxxxxxxx Cc: linux-scsi@xxxxxxxxxxxxxxx; thomas@xxxxxxxxxxx; Kolli, Neela; Seokmann.Ju@xxxxxxxx; thomas.horsten@xxxxxxxxx; Patro, Sumant Subject: Re: [patch 05/13] MegaRAID driver management char device moved tomisc On Mon, 2008-02-04 at 23:53 -0800, akpm@xxxxxxxxxxxxxxxxxxxx wrote: > From: Thomas Horsten <thomas@xxxxxxxxxxx> > > The MegaRAID driver's common management module (megaraid_mm.c) creates > a char device used by the management tool "megarc" from LSI Logic (and > possibly other management tools). > > In 2.6 with udev, this device doesn't get created because it is not > registered in sysfs. > > I first fixed this by registering a class "megaraid_mm", but realized > that this should probably be moved to misc devices, instead of taking > up a char major. This is because only 1 device is used, even if there > are multiple adapters - the minor is never used (the adapter info is > in the ioctl block sent to the driver, not detected based on the minor > number as one might think). So it is a complete waste to have an entire major taken by this. > > So it now uses a misc device which I named "megadev0" (the name that > megarc expects), and has a dynamic minor (previoulsy a dynamic major was used). > > I have tested this on my own system with the megarc tool, and it works > just as fine as before (only now the device gets created correctly by udev). > > Cc: <thomas.horsten@xxxxxxxxx> > Cc: Neela Syam Kolli <Neela.Kolli@xxxxxxxxxxx> > Cc: "Ju, Seokmann" <Seokmann.Ju@xxxxxxxx> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Neela and Sekomann or Sumant, can I ping on this ... I've no idea what this will do to the raid management tools, so I really need someone to sign off on this. James - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
