On Thu, Jan 31 2008 at 21:49 +0200, Matthew Dharm <mdharm-scsi@xxxxxxxxxxxxxxxxxx> wrote: > No. No no no. > > The ISD200 code was written by the ISD200 developers. I really don't want > to go mucking about changing what commands actually get send to the ISD200 > parts. We have no idea if the will reliably accept a 36-byte INQUIRY. > > Just because it happens to work for a couple of people doesn't mean it > works in the general case. Without guidance from In-System, this is a bad > idea. > > The way to deal with this is to do this via bounce buffering. The two > commands affected (INQUIRY and MODE_SENSE) are low-performance items. > Discarding data from the end of them is also perfectly legal per spec. > > Also, the entire idea of a negative resid makes my head hurt. That sort of > change is in the category of "likely to break something else" which only > expects positive resid values. > > Matt > Please re-inspect the code again. There is no device involved here. The code completely emulates this commands with a driver made up information. the send_to_device is Zero. (Nothing to bounce) There is one more command like that but the standard does not permit choice in that respect. The negative resid is returned by iscsi for ages so I would say the scsi-ml is fine with it. But if you want I can reset the resid and mark an overflow condition in cmnd->status. Boaz - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
