On Wed, Jan 30 2008, Jens Axboe wrote: > On Wed, Jan 30 2008, James Bottomley wrote: > > On Wed, 2008-01-30 at 11:38 +0100, Jens Axboe wrote: > > > On Wed, Jan 30 2008, Geert Uytterhoeven wrote: > > > > On Tue, 29 Jan 2008, Jens Axboe wrote: > > > > > On Tue, Jan 29 2008, Jens Axboe wrote: > > > > > > On Tue, Jan 29 2008, James Bottomley wrote: > > > > > > > On Tue, 2008-01-29 at 11:10 -0800, Matthew Dharm wrote: > > > > > > > > For some reason, usb_sg_init is boned during auto-sense. > > > > > > > > > > > > > > OK, that's implicating the scsi_eh_prep_cmnd() in the auto sense > > > > > > > code ... that was also an update in 2.6.24 > > > > > > > > > > > > yeah, already found the bug - it's assuming ->request_buffer holds the > > > > > > sglist, oops. Preparing a fix. > > > > > > > > > > ok here goes, this saves and restores the sg table correctly. it also > > > > > fixes the usb bug for me. > > > > > > > > I can confirm this patch fixes the errors I was seeing with current > > > > linux-2.6.git for the USB memory card readers in a Dell TFT connected > > > > to a PS3. > > > > > > James, we need a fix for this pushed asap. So either we should merge the > > > below now, or push the bidi patchset that also fixes this. It all > > > depends on when you want to merge the bidi patches... > > > > The SCSI patch set (including the bidirectional pieces) is waiting in > > scsi-misc ... just for forms sake, could you confirm that it actually > > fixes the problem and I'll push it. > > Certainly, I'll give it a spin tonight. Confirmed, pulling your scsi-misc branch into current -git makes the problem go away as well. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
