Tejun Heo wrote: > James Bottomley wrote: >> On Fri, 2008-01-18 at 16:20 +0900, Tejun Heo wrote: >>> aha152x.c and fdomain are built twice - once for the isa driver and >>> once for the PCMCIA one. Through #ifdefs, the compiled codes are >>> slightly different; thus, global symbols need to be given different >>> names depending on which flavor is being built. This patch adds >>> GLOBAL() macro to aha152x.h and fdomain.h which change the symbol >>> depending on PCMCIA. >>> >>> This bug has always existed but has been masked by the fact the >>> drivers/scsi/pcmcia used subdir-(y|m) instead of obj-(y|m) which made >>> drivers/scsi/pcmcia/built_in.o not linked into the kernel and thus >>> avoided the duplicate symbols during compilation. >>> >>> Signed-off-by: Tejun Heo <htejun@xxxxxxxxx> >>> --- >>> Ah... missed that one. Here's the updated version. >> Actually, isn't the better fix just to return to the original behaviour? >> >> As you pointed out, using the subdir instead of obj meant that although >> the modules were built, the drivers were never linked into the main >> kernel. According to the records, this has been the default forever, so >> there can be no-one anywhere relying on these drivers being built in. >> Actually, as old style pcmcia drivers, I'm not sure there's much value >> building them into the kernel anyway. >> >> So just modify scsi/pcmcia/Kconfig to make them all depend on m. > > Yeap, there is no problem if you don't allow them to be linked into the > kernel. If that's how you want it, please go ahead. > > I personally think it's a bit odd to disallow building into kernel > because of the peculiarity of the implementation (including c files and > compiling them slightly differently) and also no one reporting doesn't > necessarily mean no one has attempted it and failed. Actually what's better would be to make all symbols static and include the c file directly into the stub file. How about that? -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
