Andrew Morton wrote: > On Thu, 17 Jan 2008 21:45:39 +0530 Kamalesh Babulal <kamalesh@xxxxxxxxxxxxxxxxxx> wrote: > >> Hi Andrew, >> >> The kernel build fails with following error >> >> drivers/scsi/aha152x.o: In function `aha152x_host_reset_host': >> /home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/aha152x.c:1324: multiple definition of `aha152x_host_reset_host' >> drivers/scsi/pcmcia/built-in.o:/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/aha152x.c:1324: first defined here >> drivers/scsi/aha152x.o: In function `aha152x_release': >> /home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/aha152x.c:908: multiple definition of `aha152x_release' >> drivers/scsi/pcmcia/built-in.o:/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/aha152x.c:908: first defined here >> ld: Warning: size of symbol `aha152x_release' changed from 68 in drivers/scsi/pcmcia/built-in.o to 100 in drivers/scsi/aha152x.o >> drivers/scsi/aha152x.o: In function `aha152x_probe_one': > > Neat. Seems that the scsi build system is linking together two copies of > drivers/scsi/aha152x.o. One via drivers/scsi/aha152x.o directly and the > other via drivers/scsi/pcmcia/built-in.o. > > Please send the .config. > > I'm looking suspiciously at this, from git-scsi-misc: > > commit 8ae732a91df051aba6820068a47b631a06599d84 > Author: Tejun Heo <htejun@xxxxxxxxx> > Date: Fri Dec 7 22:36:23 2007 +0900 > > [SCSI] make pcmcia directory use obj-y|m instead of subdir-y|m > > subdir-y|m isn't supposed to contain modules or built-in components. > Change subdir-$(CONFIG_PCMCIA) to obj-$(CONFIG_PCMCIA). > > Signed-off-by: Tejun Heo <htejun@xxxxxxxxx> > Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > Signed-off-by: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> > > diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile > index b5441f5..93e1428 100644 > --- a/drivers/scsi/Makefile > +++ b/drivers/scsi/Makefile > @@ -17,7 +17,7 @@ > CFLAGS_aha152x.o = -DAHA152X_STAT -DAUTOCONF > CFLAGS_gdth.o = # -DDEBUG_GDTH=2 -D__SERIAL__ -D__COM2__ -DGDTH_STATISTICS > > -subdir-$(CONFIG_PCMCIA) += pcmcia > +obj-$(CONFIG_PCMCIA) += pcmcia/ > > obj-$(CONFIG_SCSI) += scsi_mod.o > obj-$(CONFIG_SCSI_TGT) += scsi_tgt.o Hi Andrew, Patch from Tejun Heo fixes the aha152x.c build failure, and following second part of the build failure, is still occurring. drivers/scsi/fdomain.o:(.data+0x0): multiple definition of `fdomain_driver_template' drivers/scsi/pcmcia/built-in.o:(.data+0x5a0): first defined here drivers/scsi/fdomain.o: In function `fdomain_16x0_bus_reset': /home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/fdomain.c:1568: multiple definition of `fdomain_16x0_bus_reset' drivers/scsi/pcmcia/built-in.o:/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/fdomain.c:1568: first defined here drivers/scsi/fdomain.o: In function `__fdomain_16x0_detect': /home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/fdomain.c:894: multiple definition of `__fdomain_16x0_detect' drivers/scsi/pcmcia/built-in.o:/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/fdomain.c:894: first defined here ld: Warning: size of symbol `__fdomain_16x0_detect' changed from 1206 in drivers/scsi/pcmcia/built-in.o to 1700 in drivers/scsi/fdomain.o drivers/scsi/fdomain.o: In function `fdomain_setup': /home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/fdomain.c:554: multiple definition of `fdomain_setup' drivers/scsi/pcmcia/built-in.o:/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/fdomain.c:554: first defined here make[2]: *** [drivers/scsi/built-in.o] Error 1 make[1]: *** [drivers/scsi] Error 2 make: *** [drivers] Error 2 -- Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
