On Thu, Jan 10, 2008 at 08:07:48PM +0100, Andre Noll wrote: > On 19:59, Andi Kleen wrote: > > > But perhaps for such a long ioctl handler it would be better to move > > the lock/unlock_kernel()s into the individual case ...: statements; > > then it could be eliminated step by step. > > Sure, I can do that if James likes the idea. Since not all case > statements need the BKL, we could add it only to those for which it > isn't clear that it is unnecessary. > > And this would actually improve something. I still think it would be a good strategy to first add it to all (in a essentially nop semantics patch) and then later eliminate it from the cases that obviously don't need it. But yes eliminating it from all is the long term goal. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
