On Thu, 2008-01-10 at 19:05 +0100, Andre Noll wrote: > [Resent with proper subject and to additional recipients] > > This patch against linus-current is compile-tested on x86 and x86-64. > > Please review This is rather long. For the utility of what you've just done, what's wrong with just making the .unlocked_ioctl point to sg_unlocked_ioctl() and doing: sg_unlocked_ioctl() int rc; lock_kernel(); rc = sg_ioctl(); unlock_kernel(); return rc; } Really, all this is doing is open coding what the ioctl handler is doing anyway, isn't it? in which case, why bother to change it at all? James - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html