On Thu, Jan 10 2008, Boaz Harrosh wrote:
> On Thu, Jan 10 2008 at 14:33 +0200, Oliver Neukum <oliver@xxxxxxxxxx> wrote:
> > Hi,
> >
> > could you explain to me why this code can get away with allocating the
> > sense buffer on the stack?
> >
> > static int sg_io(struct file *file, struct request_queue *q,
> > struct gendisk *bd_disk, struct sg_io_hdr *hdr)
> > {
> > unsigned long start_time;
> > int writing = 0, ret = 0, has_write_perm = 0;
> > struct request *rq;
> > char sense[SCSI_SENSE_BUFFERSIZE];
> >
> > Regards
> > Oliver
> > -
> where? what? do you mean in scsi_ioctl.c?
> why not it's a synchronous call?
> Do you mean 96 bytes is too big?
> Do you mean DMA alignment and cache coherency? I'm working
> on that for scsi devices.
I'm guessing aligment - so the answer is that 'it cannot get away with
it'.
--
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
