On Tue, Jan 08, 2008 at 01:17:15PM -0800, Grant Grundler wrote: > Why apply le32_to_cpu() to the constant instead of the variable? > On systems were le32_to_cpu() is doing something, can gcc or > preprocessor optimize the constant? > I've always assumed it could not but that might be wrong. $ grep constant_p include/linux/byteorder/* include/linux/byteorder/swabb.h:(__builtin_constant_p((__u32)(x)) ? \ include/linux/byteorder/swabb.h:(__builtin_constant_p((__u32)(x)) ? \ include/linux/byteorder/swab.h:(__builtin_constant_p((__u16)(x)) ? \ include/linux/byteorder/swab.h:(__builtin_constant_p((__u32)(x)) ? \ include/linux/byteorder/swab.h:(__builtin_constant_p((__u64)(x)) ? \ -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html