Matthew Wilcox wrote: >> - add more PCI device IDs >> - support for adapters based on Marvell IOP > > Are you sure it's a good idea to do this? This patch is 1200 lines long > ... the same size as the existing driver: > > $ wc drivers/scsi/hptiop.* > 947 2273 24531 drivers/scsi/hptiop.c > 256 612 6175 drivers/scsi/hptiop.h > 1203 2885 30706 total > > That suggests to me there's not much commonality between the two drivers, > and you'd be better off adding a second driver for the 4xxx cards The new adapter implementation adds to the driver about 300 lines of code (some lines in the original driver was changed slightly to accommodate the difference). It is only different from the original models on the messaging interface, and still shares same firmware command block structures and work flow. HighPoint Linux Team - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
