On Mon, 12 Nov 2007 22:06:52 -0800 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > On Thu, 08 Nov 2007 18:59:30 +0200 Boaz Harrosh <bharrosh@xxxxxxxxxxx> wrote: > > > In preparation for bidi we abstract all IO members of scsi_cmnd, > > that will need to duplicate, into a substructure. > > > > - Group all IO members of scsi_cmnd into a scsi_data_buffer > > structure. > > drivers/scsi/qla1280.c: In function 'qla1280_done': > drivers/scsi/qla1280.c:1313: error: 'struct scsi_cmnd' has no member named 'use_sg' > drivers/scsi/qla1280.c:1314: error: 'struct scsi_cmnd' has no member named 'request_buffer' > drivers/scsi/qla1280.c:1315: error: 'struct scsi_cmnd' has no member named 'use_sg' > drivers/scsi/qla1280.c:1316: error: 'struct scsi_cmnd' has no member named 'request_bufflen' > drivers/scsi/qla1280.c:1318: error: 'struct scsi_cmnd' has no member named 'request_bufflen' > drivers/scsi/qla1280.c: In function 'qla1280_return_status': > drivers/scsi/qla1280.c:1409: error: 'struct scsi_cmnd' has no member named 'request_bufflen' > drivers/scsi/qla1280.c:1416: error: 'struct scsi_cmnd' has no member named 'resid' > drivers/scsi/qla1280.c: In function 'qla1280_64bit_start_scsi': > drivers/scsi/qla1280.c:2791: error: 'struct scsi_cmnd' has no member named 'use_sg' > drivers/scsi/qla1280.c:2792: error: 'struct scsi_cmnd' has no member named 'request_buffer' > drivers/scsi/qla1280.c:2793: error: 'struct scsi_cmnd' has no member named 'use_sg' > drivers/scsi/qla1280.c:2801: error: 'struct scsi_cmnd' has no member named 'request_bufflen' > drivers/scsi/qla1280.c:2896: error: 'struct scsi_cmnd' has no member named 'use_sg' > drivers/scsi/qla1280.c:2991: error: 'struct scsi_cmnd' has no member named 'request_buffer' > drivers/scsi/qla1280.c:2992: error: 'struct scsi_cmnd' has no member named 'request_bufflen' > drivers/scsi/qla1280.c:3004: error: 'struct scsi_cmnd' has no member named 'request_bufflen' > make[2]: *** [drivers/scsi/qla1280.o] Error 1 > > It mystfies me how a patch like this can have been floating about in N > submissions across M months and nobody has done an allmodconfig build or > even a grep to find out what broke. > > ho hum. I shall mark qla1280 BROKEN and shall plod onwards. A patch to fix this is in James' scsi-pending tree. Jes tested and fixed it (thanks !) so it will go to -mm via scsi-misc soon. Boaz, it's better to send major scsi patches to -mm via scsi-misc to avoid problems like this. By the way, Andrew, can you add the following patchset to -mm? http://lkml.org/lkml/2007/10/24/138 It fixes the IOMMUs' problem to merge scatter/gather segments without considering LLDs' restrictions. Thanks, - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
