>
> > On 2/4/25 6:31 AM, Avri Altman wrote:
> > > +static ssize_t critical_health_show(struct device *dev,
> > > + struct device_attribute *attr,
> > > +char
> > > +*buf) {
> > > + struct ufs_hba *hba = dev_get_drvdata(dev);
> > > +
> > > + return sysfs_emit(buf, "%d\n", hba->dev_info.critical_health);
> > > + }
> >
> > Hi Avri,
> >
> > My understanding is that the UFS 4.1 standard supports reporting a
> > critical health event repeatedly while this patch does not allow users
> > to figure out whether a critical event has been reported once or
> > repeatedly. Has it been considered to report the number of times a
> > critical health event has been reported by a UFS device instead of only one
> bit of information?
> Done.
After some further internal discussions:
The set conditions are vendor specific; The device may set it as many times it wants depending on its criticality.
The spec does not define that nor what the host should do.
So there is this concern that some vendors will report multiple times, while other wont.
Hence, reading critical_health = 1 might be misleading.
What do you think?
Thanks,
Avri
>
> Thanks,
> Avri
>
> >
> > Thanks,
> >
> > Bart.
