Re: [PATCH v2 4/8] scsi: ufs: qcom: Implement the freq_to_gear_speed() vops

[Ziqi Chen <quic_ziqichen@xxxxxxxxxxx>]

On 1/23/2025 2:23 AM, Bart Van Assche wrote:
> On 1/22/25 2:02 AM, Ziqi Chen wrote:
> > +static int ufs_qcom_freq_to_gear_speed(struct ufs_hba *hba, unsigned 
> > long freq, u32 *gear)
> > +{
> > +    int ret = 0;
> > +
> > +    switch (freq) {
> > +    case 403000000:
> > +        *gear = UFS_HS_G5;
> > +        break;
> > +    case 300000000:
> > +        *gear = UFS_HS_G4;
> > +        break;
> > +    case 201500000:
> > +        *gear = UFS_HS_G3;
> > +        break;
> > +    case 150000000:
> > +    case 100000000:
> > +        *gear = UFS_HS_G2;
> > +        break;
> > +    case 75000000:
> > +    case 37500000:
> > +        *gear = UFS_HS_G1;
> > +        break;
> > +    default:
> > +        ret = -EINVAL;
> > +        dev_err(hba->dev, "%s: Unsupported clock freq : %lu\n", 
> > __func__, freq);
> > +        break;
> > +    }
> > +
> > +    if (!ret)
> > +        dev_dbg(hba->dev, "%s: Freq %lu to Gear %u\n", __func__, 
> > freq, *gear);
> > +
> > +    return ret;
> > +}
>
> Please simplify the above function by returning early in case of an
> unsupported clock frequency and by removing the 'ret' variable.
>
> Thanks,
>
> Bart.
Hi Bart,

looks like a good way , thanks~

-Ziqi