Re: [PATCH v2 3/8] scsi: ufs: core: Add a vops to map clock frequency to gear speed

[Ziqi Chen <quic_ziqichen@xxxxxxxxxxx>]

Hi Bart,

Thanks for you review~

On 1/23/2025 2:22 AM, Bart Van Assche wrote:
> On 1/22/25 2:02 AM, Ziqi Chen wrote:
> > From: Can Guo <quic_cang@xxxxxxxxxxx>
> >
> > Add a vops to map UFS host controller clock frequencies to the maximum
>
> Above and in the subject, please change "vops" into "vop" (variant
> operation).

OK , will update it in next version.

> >   struct ufs_hba_variant_ops {
> >       const char *name;
> > @@ -387,6 +388,8 @@ struct ufs_hba_variant_ops {
> >                          unsigned long *ocqs);
> >       int    (*config_esi)(struct ufs_hba *hba);
> >       void    (*config_scsi_dev)(struct scsi_device *sdev);
> > +    int (*freq_to_gear_speed)(struct ufs_hba *hba, unsigned long freq,
> > +                    u32 *gear);
> >   };
>
> Please keep the indentation consistent.

Sure, thanks~

> Thanks,
>
> Bart.