On 1/5/25 10:16 PM, Xiang Zhang wrote:
> The ISCSI_UEVENT_GET_HOST_STATS request is already replied to iscsid in iscsi_get_host_stats,
The lines are too long. You need to keep them shorter than 75 columns
in the commit message.
You can quickly check your patch by running:
src/linux$ scripts/checkpatch.pl your-patch.patch
Also don't forget the code comment below.
> @@ -4113,6 +4113,8 @@ iscsi_if_rx(struct sk_buff *skb)
> break;
Thanks for the update, but I think you missed the previous email:
Patch looks correct, but could you update the code comment right above
this line so it mentions ISCSI_UEVENT_GET_STATS and
ISCSI_UEVENT_GET_HOST_STATS.
> if (ev->type == ISCSI_UEVENT_GET_CHAP && !err)
> break;
> + if (ev->type == ISCSI_UEVENT_GET_HOST_STATS && !err)
> + break;
> err = iscsi_if_send_reply(portid, nlh->nlmsg_type,
> ev, sizeof(*ev));
> if (err == -EAGAIN && --retries < 0) {
