Re: [PATCH v5 06/10] scsi: ufs: core: Move the ufshcd_device_init(hba, true) call

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/12/24 10:29 PM, Bao D. Nguyen wrote:
On 9/10/2024 2:50 PM, Bart Van Assche wrote:
() plus the time wait for
async_schedule(ufshcd_async_scan, hba).

The above comment is not clear to me. I'm not aware of any code in the
UFS driver that waits for the asynchronously called ufshcd_async_scan()
function to finish? It's not clear to me either how the time spent in
ufshcd_add_scsi_host() would be included in the trace print?

+    ktime_t device_init_start;

IMO, it's kinda overkill to add this device_init_start member for the purpose of trace print the time spent in the first probe_hba() only. How about print the time spent in probe_hba() outside of the ufshcd_process_device_init_result() function so that you don't need to pass device_init_start into ufshcd_process_device_init_result()?

I will remove the above struct ufs_hba member again.

Thanks,

Bart.






[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux