Matthew Wilcox wrote:
Make sym_interrupt return an irqreturn_t instead of void, and take a
Scsi_Host instead of a sym_hcb. Pass the Scsi_Host to the interrupt
handler instead of the sym_hcb. Rename the host_data to sym_data.
Keep a pci_dev pointer in the sym_data. Rename the Scsi_Host from
instance to shost.
Signed-off-by: Matthew Wilcox <willy@xxxxxxxxxxxxxxx>
ACK
Additionally, consider checking for istat==0xffffffff and returning
IRQ_NONE, like most other drivers. This handles the window during
hot-unplug where you wind up reading a hardware register after the
hardware is gone, but before the driver has been notified of unplug.
The normal behavior of hardware for this case is to return all 1's upon
PCI device fault/unplug.
Presuming you don't have fancy-shmancy PCI error reporting hw :)
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
