On Mon, Sep 16, 2024 at 08:44:13AM +0200, Christoph Hellwig wrote: > The wrong thing primarily is the above commit log. The code change > itself is correct, but we'd be better off killing the iteration over > the bio chain as well to make the code less confusing. Okay, gotcha. I mentioned the existing code is a no op in "most cases" but it should just be "always". Maybe a sanity check with a WARN here is appropriate too. BTW, sorry for mislabeling the tags. The patch numbers changed a few times in this series, and I pasted reviews from the a different message.