On Sat, Sep 14, 2024 at 09:30:12AM +0200, Christoph Hellwig wrote: > On Fri, Sep 13, 2024 at 11:28:49AM -0700, Keith Busch wrote: > > From: Keith Busch <kbusch@xxxxxxxxxx> > > > > If a bio is merged to a request, the entire bio list is merged, so don't > > temporarily detach it from its list when counting segments. In most > > cases, bi_next will already be NULL, so detaching is usually a no-op. > > But if the bio does have a list, the current code is miscounting the > > segments for the resulting merge. > > As I explained in detail last round this is still wrong. There is > no bio list here ever. Could you explain "wrong"? If we assume there is never bio list here, then the current code is performing a useless no-op, and this patch removes it. That's a good thing, no?
