Re: [PATCH v3 3/4] scsi: ufs: core: Make ufshcd_uic_cmd_compl() easier to analyze

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/12/24 6:27 AM, Peter Wang (王信友) wrote:
On Wed, 2024-09-11 at 17:30 -0700, Bart Van Assche wrote:
@@ -5462,10 +5462,13 @@ static irqreturn_t
ufshcd_uic_cmd_compl(struct ufs_hba *hba, u32 intr_status)
spin_lock(hba->host->host_lock);
  	cmd = hba->active_uic_cmd;
+	if (!cmd)
+		goto unlock;
+

Could add a warning line in this case? 	
WARN_ON(!cmd);
I'm worried that if this situation occurs, we won't have
enough information to debug.

I will do that.

Thanks,

Bart.






[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux