Re: [PATCH 2/2] scsi: ufs: core: Fix the code for entering hibernation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/27/2024 8:42 AM, Bart Van Assche wrote:
On 8/26/24 6:39 PM, Peter Wang (王信友) wrote:
It is not a new vendor hook, ufshcd_vops_hibern8_notify is exist
in current kernel.
Hi Peter,

Is something like the untested patch below perhaps what you have in
mind?

Hi Bart, IMHO even though the patch may work, it makes the existing code more complicated with the disable_uic_compl_intr flag being sent to the platform driver that has nothing to do with it. It seems the proposal makes the code harder to read as well. A new person without any history of this issue trying to understand the purpose of this flag would probably need to spend some extra time digging the history.

Thanks, Bao




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux