On 8/23/24 5:01 AM, Manivannan Sadhasivam wrote:
Unfortunately you never mentioned which UFS controller this behavior applies to.
Does your employer allow you to publish detailed information about
unreleased SoCs?
- The workaround results in a simplification of the UFS driver core
code. More lines are removed from the UFS driver than added.
This doesn't justify the modification of the UFS code driver for an errantic
behavior of a UFS controller.
Patch 2/2 deletes more code than it adds and hence helps to make the UFS
driver core easier to maintain. Adding yet another quirk would make the
UFS driver core more complicated and hence harder to maintain.
Although it would be possible to select whether the old or the new
behavior is selected by introducing yet another host controller quirk, I
prefer not to do that because it would make the UFSHCI driver even more
complex.
I strongly believe that using the quirk is the way forward to address this
issue. Because this is not a documented behavior to be handled in the core
driver and also defeats the purpose of having the quirks in first place.
Adding a quirk is not an option in this case because adding a new quirk
without code that uses the quirk is not allowed. It may take another
year before the code that uses that new quirk is sent upstream because
the team that sends Pixel SoC drivers upstream only does this after
devices with that SoC are publicly available.
Thanks,
Bart.
