> On 5/22/24 13:56, Bao D. Nguyen wrote: > > On 5/22/2024 11:18 AM, Bart Van Assche wrote: > >> Since the described issue is only encountered during development, why to > >> modify the UIC command timeout unconditionally? > > > > The vendors can enjoy the default 500ms UIC timeout if they prefer. > > As long as they don't write to hba->uic_cmd_timeout in the vendor's > initialization routine, the default value of 500ms will be used. > > Since this issue is not vendor specific, I think it would be better to > modify the UFSHCI core driver only. Has it been considered to introduce a > kernel module parameter for setting the UIC command timeout instead of the > approach of this patch? As you probably know there are multiple mechanisms > for specifying kernel module parameters, e.g. the bootargs parameter in the > device tree. Since the problem statement is "During product development...", why not just a debugfs? Thanks, Avri > > Thanks, > > Bart.
